itschrispeck commented on PR #13527: URL: https://github.com/apache/pinot/pull/13527#issuecomment-2206959587
> Good catch! The root cause is that `NotDocIdIterator` breaks the contract that no more calls to `next()` or `advance()` are allowed after they return `EOF`. We should move modify `NotDocIdIterator.next()` to perform the check of `if (_nextDocId >= _numDocs)` first I see it now, thanks! I think the original check is still valid, I duplicated it to also check first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
