Jackie-Jiang commented on PR #13362:
URL: https://github.com/apache/pinot/pull/13362#issuecomment-2182121416

   Good point on the infinite retention case. I'm okay always removing empty 
segment as long as it is not the last committed one (used to resume consumption 
or mark the end of a partition). I think it is okay because removed segments 
are either expired or empty. I don't see much value keeping all empty segments 
around even for debugging purpose. @sajjad-moradi wdyt?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to