Jackie-Jiang commented on PR #13401: URL: https://github.com/apache/pinot/pull/13401#issuecomment-2174516543
> What would be the scenario in which we want to use Json serialization for these objects? I don't see a concrete use case, but I feel having only setters but no getters is kind of anti-pattern. This pattern is common for builders, but these classes are not just builder classes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
