shounakmk219 commented on code in PR #13296:
URL: https://github.com/apache/pinot/pull/13296#discussion_r1632598268
##########
pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java:
##########
@@ -361,7 +361,8 @@ private void putSchema(ZNRecord znRecord)
columnNameMap.put(columnName, columnName);
}
}
- _schemaInfoMap.put(schemaName, new SchemaInfo(schema, columnNameMap));
+ _schemaInfoMap.put(schemaName, new SchemaInfo(schema, columnNameMap,
schema.getDimensionFieldSpecs().size(),
+ schema.getDateTimeFieldSpecs().size(),
schema.getMetricFieldSpecs().size()));
Review Comment:
Can we derive these fields from the schema object rather than passing them
explicitly to `SchemaInfo` constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
