This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new fdfae5e57a get startTime outside the executor task to avoid flaky time
checks (#13250)
fdfae5e57a is described below
commit fdfae5e57aaeb4cd8ca2921cee33c2a45534e40c
Author: Xiaobing <61892277+klsi...@users.noreply.github.com>
AuthorDate: Tue May 28 15:56:23 2024 -0700
get startTime outside the executor task to avoid flaky time checks (#13250)
---
.../local/upsert/BasePartitionUpsertMetadataManagerTest.java | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManagerTest.java
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManagerTest.java
index 4a0d127fa7..0e97621733 100644
---
a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManagerTest.java
+++
b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManagerTest.java
@@ -34,6 +34,7 @@ import java.util.concurrent.CountDownLatch;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import javax.annotation.Nullable;
import org.apache.commons.io.FileUtils;
@@ -285,8 +286,8 @@ public class BasePartitionUpsertMetadataManagerTest {
upsertMetadataManager.replaceDocId(seg03, validDocIds03, null, seg01,
0, 12, recordInfo);
});
// This thread gets segment contexts, but it's blocked until the first
thread finishes replaceDocId.
+ long startMs = System.currentTimeMillis();
Future<Long> future = executor.submit(() -> {
- long startMs = System.currentTimeMillis();
// Check called flag to let the first thread do replaceDocId, thus get
WLock, first.
while (!called.get()) {
Thread.sleep(10);
@@ -299,7 +300,7 @@ public class BasePartitionUpsertMetadataManagerTest {
// So the 2nd thread getting segment contexts will be blocked for 2s+.
Thread.sleep(2000);
latch.countDown();
- long duration = future.get();
+ long duration = future.get(3, TimeUnit.SECONDS);
assertTrue(duration >= 2000, duration + " was less than expected");
} finally {
executor.shutdownNow();
@@ -365,8 +366,8 @@ public class BasePartitionUpsertMetadataManagerTest {
upsertMetadataManager.replaceDocId(seg03, validDocIds03, null, seg01,
0, 12, recordInfo);
});
// This thread gets segment contexts, but it's blocked until the first
thread finishes replaceDocId.
+ long startMs = System.currentTimeMillis();
Future<Long> future = executor.submit(() -> {
- long startMs = System.currentTimeMillis();
// Check called flag to let the first thread do replaceDocId, thus get
WLock, first.
while (!called.get()) {
Thread.sleep(10);
@@ -380,7 +381,7 @@ public class BasePartitionUpsertMetadataManagerTest {
// So the 2nd thread getting segment contexts will be blocked for 2s+.
Thread.sleep(2000);
latch.countDown();
- long duration = future.get();
+ long duration = future.get(3, TimeUnit.SECONDS);
assertTrue(duration >= 2000, duration + " was less than expected");
} finally {
executor.shutdownNow();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
