yashmayya commented on PR #13212: URL: https://github.com/apache/pinot/pull/13212#issuecomment-2128506148
Ah damn, I hadn't seen that. I think that the other PR has some issues though - most importantly, it doesn't handle the case where the transform function returns null for some, but not all docs (I think even you've pointed that out). Also, it doesn't create the null vector index even if the table / column has null handling enabled. On the other hand, this PR is only handling the `null` value case, whereas the other PR is also handling the case where the transform function throws an exception (this is a very small change though). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
