Jackie-Jiang commented on code in PR #13015:
URL: https://github.com/apache/pinot/pull/13015#discussion_r1609246548
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisMessageBatch.java:
##########
@@ -58,4 +68,9 @@ public StreamPartitionMsgOffset getOffsetOfNextBatch() {
public boolean isEndOfPartitionGroup() {
return _endOfShard;
}
+
+ @Override
+ public boolean hasMissingOffsets() {
+ return MessageBatch.super.hasMissingOffsets();
Review Comment:
Actually we can simply not override it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
