itschrispeck commented on PR #13199: URL: https://github.com/apache/pinot/pull/13199#issuecomment-2123700919
> I feel the current handling might not be correct. > > ``` > ANY AND T -> ANY > ANY AND F -> F > NULL AND NULL -> NULL > ``` > > The third scenario will be mistakenly count as `F`. > > We can check `_nullHandlingEnabled` and then pick the simpler handling when there is no `null`s I'm not sure that I understood correctly - say for some docs, `[null, true, false]`, is the concern that `.getFalses()` would return ids `[0, 2]` instead of `[2]`? otherwise if `_nullHandlingEnabled` is false, then `getNulls()` should be empty and it's equivalent to the simpler handling `blockDocIdSets.add(filterOperator.getTrues())` iiuc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
