Jackie-Jiang commented on code in PR #12980:
URL: https://github.com/apache/pinot/pull/12980#discussion_r1605918163
##########
pinot-plugins/pinot-input-format/pinot-protobuf/pom.xml:
##########
@@ -50,6 +50,11 @@
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
</dependency>
+ <dependency>
Review Comment:
Any specific reason why we need to override this version? This can
potentially cause version conflict.
##########
pinot-plugins/pinot-input-format/pinot-protobuf/src/test/resources/complex_type_schema.json:
##########
@@ -0,0 +1,141 @@
+{
+ "schemaName" : null,
+ "enableColumnBasedNullHandling" : false,
+ "dimensionFieldSpecs" : [ {
+ "name" : "test_message.string_field",
+ "dataType" : "STRING",
+ "notNull" : false
+ }, {
+ "name" : "test_message.int_field",
+ "dataType" : "INT",
+ "notNull" : false
+ }, {
+ "name" : "test_message.double_field",
+ "dataType" : "DOUBLE",
+ "notNull" : false
+ }, {
+ "name" : "test_message.float_field",
+ "dataType" : "FLOAT",
+ "notNull" : false
+ }, {
+ "name" : "test_message.bool_field",
+ "dataType" : "BOOLEAN",
+ "notNull" : false
+ }, {
+ "name" : "test_message.bytes_field",
+ "dataType" : "BYTES",
+ "notNull" : false
+ }, {
+ "name" : "test_message.nested_message.nested_string_field",
+ "dataType" : "STRING",
+ "notNull" : false
+ }, {
+ "name" : "test_message.nested_message.nested_int_field",
+ "dataType" : "INT",
+ "notNull" : false
+ }, {
+ "name" : "test_message.repeated_nested_messages",
+ "dataType" : "STRING",
+ "notNull" : false
+ }, {
+ "name" : "test_message.enum_field",
+ "dataType" : "STRING",
+ "notNull" : false
+ }, {
+ "name" : "test_message.nullable_string_field",
+ "dataType" : "STRING",
+ "notNull" : false
+ }, {
+ "name" : "test_message.nullable_int_field",
+ "dataType" : "INT",
+ "notNull" : false
+ }, {
+ "name" : "test_message.nullable_long_field",
+ "dataType" : "LONG",
+ "notNull" : false
+ }, {
+ "name" : "test_message.nullable_double_field",
+ "dataType" : "DOUBLE",
+ "notNull" : false
+ }, {
+ "name" : "test_message.nullable_float_field",
+ "dataType" : "FLOAT",
+ "notNull" : false
+ }, {
+ "name" : "test_message.nullable_bool_field",
+ "dataType" : "BOOLEAN",
+ "notNull" : false
+ }, {
+ "name" : "test_message.nullable_bytes_field",
+ "dataType" : "BYTES",
+ "notNull" : false
+ }, {
+ "name" : "test_message.repeated_strings",
+ "dataType" : "STRING",
+ "singleValueField" : false,
+ "notNull" : false
+ }, {
+ "name" : "test_message.repeated_ints",
+ "dataType" : "INT",
+ "singleValueField" : false,
+ "notNull" : false
+ }, {
+ "name" : "test_message.repeated_longs",
+ "dataType" : "LONG",
+ "singleValueField" : false,
+ "notNull" : false
+ }, {
+ "name" : "test_message.repeated_doubles",
+ "dataType" : "DOUBLE",
+ "singleValueField" : false,
+ "notNull" : false
+ }, {
+ "name" : "test_message.repeated_floats",
+ "dataType" : "FLOAT",
+ "singleValueField" : false,
+ "notNull" : false
+ }, {
+ "name" : "test_message.repeated_bools",
+ "dataType" : "BOOLEAN",
+ "singleValueField" : false,
+ "notNull" : false
+ }, {
+ "name" : "test_message.repeated_bytes",
+ "dataType" : "BYTES",
+ "singleValueField" : false,
+ "notNull" : false
+ }, {
+ "name" : "test_message.repeated_enums",
+ "dataType" : "STRING",
+ "singleValueField" : false,
+ "notNull" : false
+ }, {
+ "name" : "sample_record.name",
+ "dataType" : "STRING",
+ "notNull" : false
+ }, {
+ "name" : "sample_record.id",
+ "dataType" : "INT",
+ "notNull" : false
+ }, {
+ "name" : "sample_record.email",
+ "dataType" : "STRING",
+ "notNull" : false
+ }, {
+ "name" : "sample_record.friends",
+ "dataType" : "STRING",
+ "singleValueField" : false,
+ "notNull" : false
+ }, {
+ "name" : "sample_record.optionalField",
+ "dataType" : "STRING",
+ "notNull" : false
+ } ],
+ "dateTimeFieldSpecs" : [ {
+ "name" : "test_message.long_field",
+ "dataType" : "LONG",
+ "notNull" : false,
+ "format" : "1:MILLISECONDS:EPOCH",
+ "granularity" : "1:MILLISECONDS"
+ } ]
+}
Review Comment:
(format) Please add a extra empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
