Jackie-Jiang commented on code in PR #13138:
URL: https://github.com/apache/pinot/pull/13138#discussion_r1602079096
##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/utils/DriverUtils.java:
##########
@@ -49,6 +49,8 @@ public class DriverUtils {
public static final String DRIVER = "pinot";
public static final Logger LOG = LoggerFactory.getLogger(DriverUtils.class);
private static final String LIMIT_STATEMENT_REGEX = "\\s(limit)\\s";
+ private static final Pattern LIMIT_STATEMENT_REGEX_PATTERN
Review Comment:
(code style) Can you apply [Pinot
Style](https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup#intellij)
and reformat the changes
##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/utils/DriverUtils.java:
##########
@@ -212,9 +214,9 @@ public static String getJavaClassName(String
columnDataType) {
return columnsJavaClassName;
}
+
public static boolean queryContainsLimitStatement(String query) {
- Pattern pattern = Pattern.compile(LIMIT_STATEMENT_REGEX,
Pattern.CASE_INSENSITIVE);
- Matcher matcher = pattern.matcher(query);
+ Matcher matcher = LIMIT_STATEMENT_REGEX_PATTERN.matcher(query);
return matcher.find();
Review Comment:
(nit) maybe making it one line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
