soumitra-st commented on code in PR #13131:
URL: https://github.com/apache/pinot/pull/13131#discussion_r1600009620
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -229,7 +229,9 @@ public ConfigSuccessResponse addTable(String tableConfigStr,
TableConfigTunerUtils.applyTunerConfigs(_pinotHelixResourceManager,
tableConfig, schema, Collections.emptyMap());
// TableConfigUtils.validate(...) is used across table create/update.
- TableConfigUtils.validate(tableConfig, schema, typesToSkip,
_controllerConf.isDisableIngestionGroovy());
+ TableConfigUtils.validate(tableConfig, schema, typesToSkip,
_controllerConf.isDisableIngestionGroovy(),
Review Comment:
Since ZK properties can be set/changed dynamically (without restarting the
controller), I used them for this check. If you are okay with changing
disableGroovy and this check at the instance level, I can do that; let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
