yashmayya opened a new pull request, #13115: URL: https://github.com/apache/pinot/pull/13115
- We added support for generating raw derived columns during segment reload recently in https://github.com/apache/pinot/pull/13037. - An [optimization](https://github.com/apache/pinot/pull/13037#discussion_r1593104346) was pointed out where we could avoid an unnecessary extra array allocation and conversion from arrays of primitive wrapper classes to primitive arrays. - This patch adds the optimization and also adds derived numeric MV columns to the existing integration test for segment reload so that these additional code paths are covered (they previously had no test coverage). - Note that we can't simply use primitive arrays unconditionally because the [dictionary case](https://github.com/apache/pinot/blob/760e952616b79e455536bbf958edb84c8d0d3472/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java#L800) does [cast it](https://github.com/apache/pinot/blob/760e952616b79e455536bbf958edb84c8d0d3472/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentDictionaryCreator.java#L314) into an `Object[]` which isn't possible for primitive arrays. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
