davecromberge commented on PR #13020: URL: https://github.com/apache/pinot/pull/13020#issuecomment-2088109017
> The PR looks fine to me, but it is a bit strange to approve a performance wise PR without an actual benchmark we can reproduce. Could you include a JMH benchmark as part of the PR? Sure, that is a fare request. I would propose running the StarTree test under a JMH benchmark under previous and current configuration and including the results in this PR. How does that sound? Or, are you looking for a JMH test as part of the repo please could you point me to an existing test that would serve as a good example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
