klsince commented on PR #13016: URL: https://github.com/apache/pinot/pull/13016#issuecomment-2080241027
> Will the re-run cause problem? Rebalance itself should be idempotent, and rerunning it should return immediately if it is already balanced Right, rerunning returned as noop immediately. But it didn't post any job status if it's noop, so RebalanceChecker would continue to see the failure job status and retry again, entering a loop until either 1) the job status is cleaned up; 2) the table actually gets imbalanced and causes a real rebalance to happen, when new job status is posted overriding the failure status. Enhancing the cleanup mechanism would not work due to the edge case of noop as above. Because cleanup of job status is done while posting new job status. So if it's noop, no job status is posted at all, and no cleanup happens. Alternatively, we can post job status even for noop. Then, the noop status can override the old failure status. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
