Jackie-Jiang opened a new pull request, #13017: URL: https://github.com/apache/pinot/pull/13017
Refactor the code to ensure the lists used in `PinotQuery` (thrift object) are all `ArrayList`. Thrift internally always use `ArrayList`, but we might set it with other list types, such as `Arrays.asList()`, `Collections.singletonList()` etc. The problem with this is that query optimizer assumes the lists are mutable, and might modify the list. Currently query optimizer only replaces elements, which is supported by `Arrays.asList()` but not `Collections.singletonList()`. This PR ensures all lists are `ArrayList` so that it is also future proof. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
