gortiz commented on code in PR #12982:
URL: https://github.com/apache/pinot/pull/12982#discussion_r1574559296
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -260,10 +276,18 @@ protected BrokerResponse handleRequest(long requestId,
String query, @Nullable S
brokerResponse.setPartialResult(isPartialResult(brokerResponse));
// Set total query processing time
- // TODO: Currently we don't emit metric for QUERY_TOTAL_TIME_MS
long totalTimeMs = TimeUnit.NANOSECONDS.toMillis(
sqlNodeAndOptions.getParseTimeNs() + (executionEndTimeNs -
compilationStartTimeNs));
brokerResponse.setTimeUsedMs(totalTimeMs);
+ if (brokerResponse.isNumGroupsLimitReached()) {
+ for (String tableName : tableNames) {
+ _brokerMetrics.addMeteredTableValue(tableName,
BrokerMeter.BROKER_RESPONSES_WITH_NUM_GROUPS_LIMIT_REACHED, 1);
+ }
Review Comment:
I think it is better to have _false positives_ (aka report the problem at
least once) than _false negatives_ (aka report it at most once), but given
there is no consensus, I'm going to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
