gortiz commented on PR #12979: URL: https://github.com/apache/pinot/pull/12979#issuecomment-2068638072
So... IICU: - Shading is enabled by default - Some projects disable it - In some projects we can tune whether it is enabled or not by using a property Is that correct? PS: I guess we can discuss this in another PR but... why do we need shade to be on by default? I think we should only shade drivers and some plugins and at least it should be pretty safe to only turn shade on in profile `bin-dist`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
