xiangfu0 commented on code in PR #12940:
URL: https://github.com/apache/pinot/pull/12940#discussion_r1574150144
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##########
@@ -135,6 +137,13 @@ protected void postprocess(Context context) {
_controllerMetrics.setValueOfGlobalGauge(ControllerGauge.UPSERT_TABLE_COUNT,
context._upsertTableCount);
_controllerMetrics.setValueOfGlobalGauge(ControllerGauge.DISABLED_TABLE_COUNT,
context._disabledTables.size());
+ // metric for total number of tables using a particular tier backend
+ context._tierBackendTableCountMap.forEach((tier, count) ->
+ _controllerMetrics.setOrUpdateGauge(tier +
ControllerGauge.TIER_BACKEND_TABLE_COUNT.getGaugeName(), count));
Review Comment:
You also need to handle metrics deletion right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
