Jackie-Jiang commented on code in PR #12712: URL: https://github.com/apache/pinot/pull/12712#discussion_r1571052707
########## pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/pom.xml: ########## @@ -35,6 +35,6 @@ <url>https://pinot.apache.org/</url> <properties> <pinot.root>${basedir}/../../..</pinot.root> - <phase.prop>none</phase.prop> + <shade.phase.prop>none</shade.phase.prop> Review Comment: (minor) Not needed? ########## pom.xml: ########## @@ -2209,6 +2211,9 @@ <!-- Exclude build targets --> <exclude>**/target/**</exclude> + <!-- Exclude Maven plugin generated files --> + <exclude>**/dependency-reduced-pom.xml</exclude> Review Comment: I never saw this file generated ########## pinot-perf/pom.xml: ########## @@ -214,7 +214,6 @@ <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-shade-plugin</artifactId> - <version>3.1.0</version> Review Comment: Do we need to keep this plugin? I guess we should never package pinot-perf? ########## pinot-plugins/pinot-file-system/pinot-s3/pom.xml: ########## @@ -65,55 +65,4 @@ <scope>test</scope> </dependency> </dependencies> - - <profiles> - <profile> - <id>build-shaded-jar</id> - <activation> - <property> - <name>skipShade</name> Review Comment: Do we want to keep this option in the main pom? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
