chenboat commented on code in PR #12744:
URL: https://github.com/apache/pinot/pull/12744#discussion_r1558089422
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/RealtimeSegmentConverter.java:
##########
@@ -118,6 +118,9 @@ public void build(@Nullable SegmentVersion segmentVersion,
ServerMetrics serverM
genConfig.setNullHandlingEnabled(_nullHandlingEnabled);
genConfig.setSegmentZKPropsConfig(_segmentZKPropsConfig);
+ // flush any artifacts to disk to improve immutable segment build
Review Comment:
Flushing to disk is just one kind of commit action, right? See the comments
added for the commit() call. I think in general all kind of preparation is
possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
