Jackie-Jiang commented on PR #12754: URL: https://github.com/apache/pinot/pull/12754#issuecomment-2040327692
@robertzych Sure, we can file an issue and confirm what I did is necessary. The long term plan could be we maintain our own parser just for Pinot. Currently Calcite parser tries to adapt to all SQL dialects from different DBs, which can be confusing. Taking `DATE_TRUNC` as an example (the one I have to modify): - The standard one: `DATE_TRUNC(YEAR, timestamp)` - BigQuery: `DATE_TRUNC(d, YEAR)` - Redshift: `DATE_TRUNC('year', DATE '2008-09-08')` - Postgres: `DATE_TRUNC(text, timestamp with time zone, text)` (not supported) - Pinot: Similar to Postgres but with 2-5 arguments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org