Jackie-Jiang commented on code in PR #12739: URL: https://github.com/apache/pinot/pull/12739#discussion_r1554045076
########## docker/images/pinot/etc/jmx_prometheus_javaagent/configs/broker.yml: ########## @@ -1,76 +1,90 @@ rules: -- pattern: "\"org.apache.pinot.common.metrics\"<type=\"BrokerMetrics\", name=\"pinot.broker.([^\\.]*?).authorization\"><>(\\w+)" - name: "pinot_broker_authorization_$2" +- pattern: "\"org.apache.pinot.common.metrics\"<type=\"BrokerMetrics\", name=\"pinot.broker.(([^\\.]+)\\.)?([^\\.]*?).authorization\"><>(\\w+)" Review Comment: So here I can see 3 things we need to figure out: 1. Do we need to escape `.` when it is within `[]`? I tried it in java regex and `[^\\.]` and `[^.]` are equivalent. 2. Do we need to escape `.` when it is not in the matching parenthesis? 3. Do we need `*?` over `*`? IMO if `.` is handled correctly, greedy one (`*`) should be better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
