Jackie-Jiang commented on code in PR #12752: URL: https://github.com/apache/pinot/pull/12752#discussion_r1552686264
########## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TlsIntegrationTest.java: ########## @@ -524,6 +524,9 @@ public void testJDBCClient() ResultSet resultSet = statement.executeQuery(query); resultSet.first(); Assert.assertTrue(resultSet.getLong(1) > 0); + resultSet.close(); Review Comment: Consider using try-with-resource? We should also close them for the following invalid connection -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org