zhtaoxiang commented on code in PR #12739:
URL: https://github.com/apache/pinot/pull/12739#discussion_r1545985390
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java:
##########
@@ -241,7 +242,7 @@ public void cleanupSegmentCountGauge(final String resource)
{
@VisibleForTesting
public static String makeGaugeName(final String resource, final String
gaugeName) {
- return "pinot.controller." + resource + "." + gaugeName;
+ return "pinot.controller." + StringUtils.replaceOnce(resource, ".", "#") +
"." + gaugeName;
Review Comment:
If that is the case, then everyone needs to follow this usage pattern. If
anyone breaks this pattern, then the logic does not work.
Is it possible to put some logic to enforce the usage pattern? Or at least
put some java doc so that everyone will follow this usage pattern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
