chenboat commented on code in PR #12680: URL: https://github.com/apache/pinot/pull/12680#discussion_r1544963199
########## pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java: ########## @@ -280,6 +282,34 @@ private List<GenericRow> createTestData() return rows; } + @Test + public void testMultiTermRegexSearch() + throws Exception { + // Search in SKILLS_TEXT_COL column to look for documents that have the /.*ealtime stream system.*/ regex pattern + List<Object[]> expected = new ArrayList<>(); + expected.add(new Object[]{1010, + "Distributed systems, Java, realtime streaming systems, Machine learning, spark, Kubernetes, distributed " + + "storage, concurrency, multi-threading"}); + expected.add(new Object[]{1019, + "C++, Java, Python, realtime streaming systems, Machine learning, spark, Kubernetes, transaction processing, " + + "distributed storage, concurrency, multi-threading, apache airflow"}); + + String query = + "SELECT INT_COL, SKILLS_TEXT_COL FROM MyTable WHERE TEXT_MATCH(SKILLS_TEXT_COL, '*ealtime streaming system*') " + + "LIMIT 50000"; Review Comment: Test cases added and they work! Though it is not the main intent of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org