Jackie-Jiang commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1538601907


##########
pinot-connectors/pinot-flink-connector/pom.xml:
##########
@@ -51,7 +51,18 @@
     </dependency>
     <dependency>
       <groupId>org.apache.flink</groupId>
-      <artifactId>flink-streaming-java_${scala.compat.version}</artifactId>
+      <artifactId>flink-streaming-java</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.flink</groupId>
+      <artifactId>flink-java</artifactId>
+      <exclusions>

Review Comment:
   Ideally we want to do the exclusion within the root pom. Which 2 libraries 
have conflict? Should we explicitly manage the version of this library?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to