klsince commented on code in PR #12722:
URL: https://github.com/apache/pinot/pull/12722#discussion_r1538329352
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -199,14 +199,19 @@ public void preloadSegments(IndexLoadingConfig
indexLoadingConfig) {
return;
}
// From now on, the _isPreloading flag is true until the segments are
preloaded.
+ long startTime = System.currentTimeMillis();
Review Comment:
I think doPreloadSegments method is coarse enough (taking many seconds if
not minutes) to offset the measurement error here. I'd use nanoTime when to
measure very fine grained methods like those on the query execution path and
those supposed to be finish in many ms or even under ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
