gortiz commented on code in PR #12591:
URL: https://github.com/apache/pinot/pull/12591#discussion_r1534267382
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/queries/QueryRunnerTest.java:
##########
@@ -258,7 +258,7 @@ private Object[][] provideTestSqlAndRowCount() {
+ "col1, COUNT(*) FROM a GROUP BY col1", 2},
new Object[]{"SET numGroupsLimit = 2; SELECT /*+
aggOptions(num_groups_limit='1') */ "
+ "a.col2, b.col2, COUNT(*) FROM a JOIN b USING (col1) GROUP BY
a.col2, b.col2", 1},
- new Object[]{"SELECT * FROM \"tbl-escape.naming\"", 5}
+ new Object[]{"SELECT * FROM \"default.tbl-escape-naming\"", 5}
Review Comment:
Even double quoted names are interpreted as database + table name? I would
have expected to support things like `select * from db1."some.name.with.dots"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
