Jackie-Jiang opened a new pull request, #12684:
URL: https://github.com/apache/pinot/pull/12684
Currently in order to use segment size based commit threshold, rows must be
explicitly set to 0. This is very confusing because usually people only set the
threshold they want to honor.
With the PR:
- When `rows == 0`: use segment size based (backward compatible)
- When `rows > 0`: use rows
- When `rows < 0` (or not set):
- When `segment size > 0`: use segment size
- When `segment size <= 0` (or not set): use default rows
Also fail the invalid config instead of silently using default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
