Jackie-Jiang commented on code in PR #12201:
URL: https://github.com/apache/pinot/pull/12201#discussion_r1529293061
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableInstances.java:
##########
@@ -170,9 +171,12 @@ public List<String> getLiveBrokersForTable(
@ApiResponses(value = {
@ApiResponse(code = 200, message = "Success"), @ApiResponse(code = 500,
message = "Internal server error")
})
- public Map<String, List<InstanceInfo>> getLiveBrokers(@Context HttpHeaders
headers) {
+ public Map<String, List<InstanceInfo>> getLiveBrokers(@Context HttpHeaders
headers,
+ @ApiParam(value = "Table name list(with or without type)",
allowMultiple = true)
+ @QueryParam("tableNameList") List<String> tableNameList) {
Review Comment:
Suggest naming the parameter `"tables"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
