rohityadav1993 commented on code in PR #11983:
URL: https://github.com/apache/pinot/pull/11983#discussion_r1528985173
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -918,32 +918,43 @@ static void validatePartialUpsertStrategies(TableConfig
tableConfig, Schema sche
UpsertConfig upsertConfig = tableConfig.getUpsertConfig();
assert upsertConfig != null;
Map<String, UpsertConfig.Strategy> partialUpsertStrategies =
upsertConfig.getPartialUpsertStrategies();
+ String partialUpsertMergerClass =
upsertConfig.getPartialUpsertMergerClass();
+
Review Comment:
@Jackie-Jiang , @deemoliu , we may want to disallow defualtMergerStrategy to
be defined when using partialUpsertMergerClass. This will require us to modify
UpsertConfig.class default initialization: `private Strategy
_defaultPartialUpsertStrategy = Strategy.OVERWRITE;` And handle this
initilization in `POST /tableConfigs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
