ankitsultana commented on PR #12538:
URL: https://github.com/apache/pinot/pull/12538#issuecomment-2000468919
I ran some tests and I see that old-gen is worse with this change vs not
setting any hash-function at all.
```
num #instances #bytes class name (module)
-------------------------------------------------------
1: 123313867 5919065616
java.util.concurrent.ConcurrentHashMap$Node (java.base@11.0.22)
2: 123395855 4961387056 [B (java.base@11.0.22)
3: 123212269 4928490760
org.apache.pinot.segment.local.upsert.ConcurrentMapPartitionUpsertMetadataManager$RecordLocation
4: 123212269 3942792608 org.apache.pinot.spi.utils.ByteArray
5: 10901 2153606592 [I (java.base@11.0.22)
6: 907 2149323976
[Ljava.util.concurrent.ConcurrentHashMap$Node; (java.base@11.0.22)
7: 14747 24051696 [C (java.base@11.0.22)
8: 2954 18350504 [J (java.base@11.0.22)
...
```
```
num #instances #bytes class name (module)
-------------------------------------------------------
1: 123392066 7918671528 [B (java.base@11.0.22)
2: 123310544 5918906112
java.util.concurrent.ConcurrentHashMap$Node (java.base@11.0.22)
3: 123209015 4928360600
org.apache.pinot.segment.local.upsert.ConcurrentMapPartitionUpsertMetadataManager$RecordLocation
4: 123245008 3956561736 [Ljava.lang.Object; (java.base@11.0.22)
5: 123378686 3948117952 java.lang.String (java.base@11.0.22)
6: 123209015 2957016360
org.apache.pinot.spi.data.readers.PrimaryKey
7: 11013 2153608640 [I (java.base@11.0.22)
8: 921 2149325080
[Ljava.util.concurrent.ConcurrentHashMap$Node; (java.base@11.0.22)
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
