shounakmk219 commented on code in PR #12591:
URL: https://github.com/apache/pinot/pull/12591#discussion_r1525803690
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java:
##########
@@ -44,14 +50,46 @@
*/
public class PinotCatalog implements Schema {
+ public static final String DEFAULT_DB_NAME = "default";
Review Comment:
This decision was made as part of #12417 . This has some history related to
the existing integrations that we have with integrations such as
[superset](https://github.com/python-pinot-dbapi/pinot-dbapi/blob/master/pinotdb/sqlalchemy.py#L223),
[presto](https://github.com/prestodb/presto/blob/master/presto-pinot-toolkit/src/main/java/com/facebook/presto/pinot/PinotMetadata.java#L62),
etc where we currently use `default` as the schema/database name placeholder
and using any other name may break existing flows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
