shounakmk219 commented on code in PR #12417: URL: https://github.com/apache/pinot/pull/12417#discussion_r1517986003
########## pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java: ########## @@ -71,6 +73,8 @@ public class TableCache implements PinotConfigProvider { private static final String LOWER_CASE_OFFLINE_TABLE_SUFFIX = OFFLINE_TABLE_SUFFIX.toLowerCase(); private static final String LOWER_CASE_REALTIME_TABLE_SUFFIX = REALTIME_TABLE_SUFFIX.toLowerCase(); + private static final String DEFAULT_DATABASE_PREFIX = CommonConstants.DEFAULT_DATABASE + "."; Review Comment: iirc this was preemptively introduced to make life easy for v2 engine. But we anyways need to handle v2 engine part separately so I'll remove this part form here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org