richardstartin commented on code in PR #12587:
URL: https://github.com/apache/pinot/pull/12587#discussion_r1516566318
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/creator/VarByteChunkV4Test.java:
##########
@@ -46,73 +47,122 @@
public class VarByteChunkV4Test {
- private static final File TEST_DIR = new File(FileUtils.getTempDirectory(),
"VarByteChunkV4Test");
+ private static File[] _dirs;
- private File _file;
-
- @DataProvider
+ @DataProvider(parallel = true)
Review Comment:
I think that testing in parallel is a better test, which would survive
refactoring. Otherwise you're verifying the implementation in two places, and
if you ever change the implementation, you lose the diagnostic power of the
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
