Jackie-Jiang commented on code in PR #12523:
URL: https://github.com/apache/pinot/pull/12523#discussion_r1513554428
##########
pinot-controller/src/main/java/org/apache/pinot/controller/util/ConsumingSegmentInfoReader.java:
##########
@@ -132,7 +133,8 @@ private Map<String, List<SegmentConsumerInfo>>
getConsumingSegmentsInfoFromServe
if (failedParses != 0) {
LOGGER.warn("Failed to parse {} / {} segment size info responses from
servers.", failedParses, serverUrls.size());
}
- return serverToConsumingSegmentInfoList;
+ return new ConsumingSegmentsInfoFromServersResponse(
+ serverToConsumingSegmentInfoList,
serviceResponse._failedResponseCount);
Review Comment:
Since we are gathering the servers not responded, should we also include
un-parsable responses as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
