xiangfu0 commented on code in PR #12546:
URL: https://github.com/apache/pinot/pull/12546#discussion_r1511722273
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -212,7 +211,7 @@ public Map<String, String> createTask(String taskType,
String tableName, @Nullab
taskGenerator.getMaxAttemptsPerTask()));
}
if (responseMap.isEmpty()) {
- throw new NoTaskScheduledException("No task scheduled for 'tableName': "
+ tableName);
Review Comment:
Just curious why we throw exception here in the previous implementation,
will both adhoc and scheduled tasks handle this correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
