swaminathanmanish commented on PR #12529: URL: https://github.com/apache/pinot/pull/12529#issuecomment-1973361126
> LGTM > > Is the agreement is to not use the context? Yes it looks like the purpose of a RecordTransformer is to transform a GenericRecord. independent of file/record reader. Until we clearly understand need, we will use RecordReader itself to do the transformation and not change the API. Hence this change to init/close custom readers within the SegmentProcessorFramework itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
