gortiz commented on PR #12522: URL: https://github.com/apache/pinot/pull/12522#issuecomment-1970846422
I like the idea, but I'm not sure if the current implementation is correct. Specifically, the scenario that concerns me is the one where: - we fetch batches far often than the Prometheus polling rate - the source mostly emits non empty batches In that scenario it seems possible that `REALTIME_LAST_FETCHED_BATCH_SIZE` would be 0 each time Prometheus polls it even if we are actually ingesting. Instead of being a gauge, we could have something like: `REALTIME_FETCHED_ROWS` which could be a counter. This metric would be non decrement and we could just apply `rate` (or some other operation) to that metric. If it doesn't increase in a while, we can be sure that there are no data in the source and therefore we can skip some alerts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
