Jackie-Jiang commented on PR #12243: URL: https://github.com/apache/pinot/pull/12243#issuecomment-1970056042
The interface for `RecordEnricher` is almost identical to `RecordTransformer`, so I believe we should be able to implement the enricher as a special transformer. I do see the limitation of not able to expend one record into multiple with `RecordTransformer` because the logic is handled before invoking record transformation, but we should be able to handle that by improving `TransformPipeline` to check `GenericRow.MULTIPLE_RECORDS_KEY` for the result of each transformation. My concern of introducing enricher as a separate module is that user/develop might get confused of when to use enricher vs transformer as they are essentially doing the same thing. It would be great if we can unify them into the same module. As for the data type, don't worry about that as `ExpressionTransformer` is also applied before `DataTypeTransformer`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
