rohityadav1993 commented on issue #10896: URL: https://github.com/apache/pinot/issues/10896#issuecomment-1968398090
@Jackie-Jiang `segmentPartitionConfig` makes sense. The problem is at a different place. If we upload an offline segment (Controller identifies this from offline segment naming convention `testtable_1695407400000_1695414594000_0_1`) it is able to figure out the partition from name and assign to right server. The server fails to load the segment due the LLCSegment name validation. If we create a segment name following the LLCSegment naming convention, the controller tries to add it to upsert table but fails it during metadata validation essentially failing the upload. I believe we will have to refine the validations to make backfills to upsert tables work. It can also be useful to discuss if we want to allow offline segment names for realtime upsert table or introduce a new naming convention which can have its own validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
