satishd commented on PR #12479:
URL: https://github.com/apache/pinot/pull/12479#issuecomment-1964320158
We can extract a method like below and add a UT for this method to check
whether the `HttpClientBuilder` instance is updated with all the targeted
configs passed to `HttpClientConfig` while building `HttpClient`. WDYT?
```
static void setConfigsToHttpClientBuilder(HttpClientConfig
httpClientConfig, HttpClientBuilder httpClientBuilder) {
if (httpClientConfig.getMaxConnTotal() > 0) {
httpClientBuilder.setMaxConnTotal(httpClientConfig.getMaxConnTotal());
}
if (httpClientConfig.getMaxConnPerRoute() > 0) {
httpClientBuilder.setMaxConnPerRoute(httpClientConfig.getMaxConnPerRoute());
}
if (httpClientConfig.isDisableDefaultUserAgent()) {
httpClientBuilder.disableDefaultUserAgent();
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
