dttung2905 commented on code in PR #12386: URL: https://github.com/apache/pinot/pull/12386#discussion_r1500064984
########## pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStartableUtils.java: ########## @@ -61,6 +65,7 @@ public static void applyClusterConfig(PinotConfiguration instanceConfig, String .build(); zkClient.waitUntilConnected(zkClientConnectionTimeoutMs, TimeUnit.MILLISECONDS); + setupTimezone(instanceConfig); Review Comment: Hmm so what do you suggest we do in this case? Should we call `setupTimezone(instanceConfig)` twice: in both line 73 before the `return` and in line 94 at the end of the method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org