xiangfu0 commented on code in PR #12417:
URL: https://github.com/apache/pinot/pull/12417#discussion_r1494739384
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -420,6 +422,12 @@ public void start()
* @param brokerAdminApplication is the application
*/
protected void registerExtraComponents(BrokerAdminApiApplication
brokerAdminApplication) {
+ brokerAdminApplication.register(new AbstractBinder() {
Review Comment:
I thought this is for override?
Shall we move this `bind(_tableCache).to(TableCache.class);` to `start()`
method.
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -420,6 +422,12 @@ public void start()
* @param brokerAdminApplication is the application
*/
protected void registerExtraComponents(BrokerAdminApiApplication
brokerAdminApplication) {
+ brokerAdminApplication.register(new AbstractBinder() {
Review Comment:
I thought this is for override?
Shall we move this `bind(_tableCache).to(TableCache.class);` to `start()`
method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
