aishikbh commented on code in PR #12361:
URL: https://github.com/apache/pinot/pull/12361#discussion_r1479573707
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/StarTreeBuilderUtils.java:
##########
@@ -83,6 +85,27 @@ public static List<StarTreeV2BuilderConfig>
generateBuilderConfigs(@Nullable Lis
return builderConfigs;
}
+ public static List<StarTreeV2BuilderConfig> generateBuilderConfigs(@Nullable
List<StarTreeIndexConfig> indexConfigs,
+ boolean enableDefaultStarTree, Schema schema, JsonNode segmentMetadata) {
+ List<StarTreeV2BuilderConfig> builderConfigs = new ArrayList<>();
+ if (indexConfigs != null) {
+ for (StarTreeIndexConfig indexConfig : indexConfigs) {
+ StarTreeV2BuilderConfig builderConfig =
StarTreeV2BuilderConfig.fromIndexConfig(indexConfig);
+ if (!builderConfigs.contains(builderConfig)) {
Review Comment:
`equals()` is overridden properly :
[here](https://github.com/apache/pinot/blob/5c81c0a88a0a95e5bf150363bb3ed5b5203de795/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/StarTreeV2BuilderConfig.java#L245-L256).
reused it in the equality test as well. Thank you for pointing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
