BrendanStans21 opened a new pull request, #12356: URL: https://github.com/apache/pinot/pull/12356
PinotDriver.connect() leaks the PinotClientTransport and PinotControllerTransport if an exception is thrown. I added unit tests to test both a bad URL and a good URL that doesn't connect. I performed manual tests of the closeResourceSafely method as it is a small private method. I performed the test by debugging the code through that method and verify the two resource do indeed close if there is an exception thrown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
