vvivekiyer commented on code in PR #12347:
URL: https://github.com/apache/pinot/pull/12347#discussion_r1475548266
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountRawThetaSketchAggregationFunction.java:
##########
@@ -53,7 +53,8 @@ public String extractFinalResult(List<ThetaSketchAccumulator>
accumulators) {
int numAccumulators = accumulators.size();
List<Sketch> mergedSketches = new ArrayList<>(numAccumulators);
- for (ThetaSketchAccumulator accumulator : accumulators) {
+ for (Object object : accumulators) {
Review Comment:
Can we please test this if this indeeds helps?
As discussed offline, as a result of the aggregationFunction.merge() step,
all Sketch objects should be converted to ThetaSketchAccumulator. So can you
clarify why we saw this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
