Jackie-Jiang commented on code in PR #12351:
URL: https://github.com/apache/pinot/pull/12351#discussion_r1475219741
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java:
##########
@@ -46,6 +50,13 @@
* 3. Delete an existed segment.
*/
public class SegmentOnlineOfflineStateModelFactory extends
StateModelFactory<StateModel> {
+ // NOTE: Helix might process CONSUMING -> DROPPED transition as 2 separate
transitions: CONSUMING -> OFFLINE followed
+ // by OFFLINE -> DROPPED. Use this cache to track the segments that just
went through CONSUMING -> OFFLINE transition
+ // to detect CONSUMING -> DROPPED transition.
+ // TODO: Check how Helix handle CONSUMING -> DROPPED transition and remove
this cache if it's not needed.
+ private final Cache<Pair<String, String>, Boolean>
_recentlyOffloadedConsumingSegments =
Review Comment:
I prefer keeping it here since it is just a workaround for Helix state
transition handling. Once Helix fixes the problem we should be able to remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
