snleee commented on code in PR #12346:
URL: https://github.com/apache/pinot/pull/12346#discussion_r1474232231
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java:
##########
@@ -160,6 +170,20 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
return pinotTaskConfigs;
}
+ private String getDefaultValidDocId(UpsertConfig upsertConfig) {
Review Comment:
@Jackie-Jiang I found that the snapshot is only available if
enableSnapshot=true. So, we need to check the upsert config and pick the
validDocIdType appropriately.
Should we perform upsert at the best effort or do we want to enforce
`enableSnapshot=true`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
