t0mpere commented on code in PR #12307:
URL: https://github.com/apache/pinot/pull/12307#discussion_r1463286640
##########
pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java:
##########
@@ -201,16 +200,16 @@ private static Configuration loadProperties(String
configPath) {
private static Map<String, Object> relaxConfigurationKeys(Configuration
configuration) {
return CommonsConfigurationUtils.getKeysStream(configuration).distinct()
- .collect(Collectors.toMap(PinotConfiguration::relaxPropertyName, key
-> configuration.getProperty(key)));
+ .collect(Collectors.toMap(PinotConfiguration::relaxPropertyName,
configuration::getProperty));
}
private static Map<String, String> relaxEnvironmentVariables(Map<String,
String> environmentVariables) {
- return environmentVariables.entrySet().stream().filter(entry ->
entry.getKey().startsWith("PINOT_"))
+ return environmentVariables.entrySet().stream().filter(entry ->
entry.getKey().startsWith(ENV_PREFIX))
Review Comment:
At the moment (before and after my changes) `<PREFIX>_SERVER_xxx` is mapped
to `server.xxx`. I've just changed the prefix to avoid confusion since
`pinot.server.property` will be loaded from `PINOT_PINOT_SERVER_PROPERTY`.
Considering that env wasn't loaded until now I think there's no worries about
backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
